On Mon, 30 Jul 2012, Paul T. Bauman wrote:
I don't follow: if the user calls get_dphidx, dphi and all the
components will be calculated and everything is fine (calculate_dphi
gets set to true in all those methods). This case will only break if
get_dphi, get_dphidx, etc. are *not* called, but the user wants
get_dphieta (*reference* shape function derivatives, changed to eta
instead of xi for clarity).
Ah - my misunderstanding - you wrote dphidxi, I read dphidx.
So if we really want to support this case, how do you want to
support it?
I'd like to support that case on general principles, but it's hard to
imagine any codes using it. Maybe some componentized multiphysics
with separate FE objects for each component, where one component
includes both a reaction term and a reference-frame-derivative-based
stabilization operator but no advection or diffusion?
Why can't we set "calculate_dphi = true" there? I'd rather take the
component arrays out entirely than leave them in there booby-trapped.
1. Performance - The reference shape function derivatives are needed
for calculating the divergence and curl, as well as the gradient,
but I may not need the gradients. The curl-curl model problem is an
example of this. Thus, as it was, calling get_dphidxi in the
FETransformation object would force dphi to be calculated when I
didn't want it to be.
So it sounds like long-term we'd like to have "calculate_dphidxi" be
a separate bool; short-term your patch is just fine as-is.
---
Roy
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel
