On Dec 12, 2012, at 12:04 PM, Roy Stogner <royst...@ices.utexas.edu> wrote:

>> 
>> Also, I have some libMesh changes that I'm going to be making today,
>> so I was thinking about my Git workflow a little bit.  I think even
>> _I_ am going to clone the libMesh Git repo on GitHub over into my
>> own workspace and work on my own changes there and then submit a
>> pull request when those changes are ready.  "Submit a pull request"
>> is essentially akin to emailing a patch so others can ok your work.
> 
> Ben and I (at least) haven't been getting the automatic emails that
> libMesh pull requests are supposed to generate; you might want to ping
> -devel at the same time until we get that sorted out.

I got an email notification from John earlier on an Issue - my problem was I 
was not 'watching' libMesh.  Kinda figured that would be the default as an 
'Owner', but maybe not.  It'll be nice to see if that is fixed now.

>> Now, if I submit a pull request and everyone is ok with it... I can
>> do my own pull into the officially libMesh git clone on my
>> workstation and merge to master and push on my own.
> 
> I'd have interpreted a pull request as an invitation for *anyone* to
> do the merge to master & push.  Not a good idea?

It would seem that in this case a pull request would be a good point for us to 
all go have our usual 'what to you think of this patch'  discussion, but in a 
more modern way!?

In any case, I'm all for you doing this - if nothing else to watch the process 
unfold.

-Ben


------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel

Reply via email to