On 12/14/2012 12:11 AM, Roy Stogner wrote: > > On Thu, 13 Dec 2012, David Knezevic wrote: > >> I'm a git noob, so I'm just trying to get started with something >> simple... If someone could confirm that the following is sensible, >> that'd be helpful: >> >> - I forked libmesh / libmesh to create dknez / libmesh on github, and >> cloned my fork locally >> - In my local clone I made a remote called "upstream" corresponding to >> https://github.com/libmesh/libmesh.git >> - I made a small change ("Removed incorrect assert in >> equation_systems.C") and pushed it to dknez / libmesh >> - I then made a pull request for this two-line change. So now I can just >> wait for the "integration manager" to commit the patch? > > This is exactly what I did today; modulo change details. So in the > worst case we're insensible in the same way. > > Our current definition of "integration manager" is probably "whoever > feels comfortable enough committing it with only two sets of eyes on > it". > > Actually, though, in this case I had an issue brought up by your patch > - while you're at it, would you take a look at the assert immediately > below the one you just removed? Looks like someone wrote dim*n_vars > where they meant dim*this->n_vars()?
Agreed. "All vector variables" (as stated in the comment) would give n_vars = dim*this->n_vars(). > >> The only other thing I need is to be able to fetch from main repo in my >> local repo, and I thought "git fetch upstream" would do the job for >> that, but I get the error: >> "fatal: >> https://github.com/libmesh/libmesh.git/info/refs?service=git-upload-pack >> not found: did you run git update-server-info on the server?" >> which is discussed on this page: >> https://help.github.com/articles/https-cloning-errors >> >> But my git version is 1.8.0, so that should be fine. I was wondering if >> the error might be due to permissions in the libmesh / libmesh repo? >> (but I would've thought I'd only need read access to fetch...) > > This, I have no idea about - I switched my URLs to ssh as soon as I > figured out how to upload the public key. OK, I'd like to switch to SSH too, but I believe need write access for that (at least according to this: https://help.github.com/articles/which-remote-url-should-i-use). Can I get write access ;) BTW, I changed my username wrt sourceforge (for no particular reason), it's now dknez. David ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ Libmesh-devel mailing list Libmesh-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libmesh-devel
