Hm... I'd be tempted to add this to our contrib/, after I think about
a few small worries:

It's not header-only, whereas I'd like to keep getpot.h header-only
for use in non-libMesh projects, so I'd have to add some more "here's
what to fall back on when not in libMesh" code to point it back to
rand().

It requires int32_t, which technically didn't make it from C99 into
C++ until C++11... but it looks like we've been depending on int32_t
since John added that hashword.h header in 2011, and nobody's
complained yet.

Anyone already linking to different versions of it could be in for a
nasty surprise when it got built into libmesh.so and incompatible
APIs manifested.
---
Roy

------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel

Reply via email to