On Thu, Jan 31, 2013 at 8:45 AM, Kirk, Benjamin (JSC-EG311) <benjamin.kir...@nasa.gov> wrote: > On Jan 31, 2013, at 9:41 AM, John Peterson <peter...@cfdlab.ae.utexas.edu> > wrote: > >> BTW, I'm not sure we should ever add -Wshadow to default compiler >> flags for libmesh! Any apps compiling using libmesh_CXXFLAGS would >> suddenly explode with new (usually innocuous) warnings > > If we don't we will continue to write shadowed code ourselves…
Very true. > So I propose we add them to the git repo, potentially removing them for a > particular release? How about a buildbot configuration with -Wshadow turned on? It's something we can let go for a while and then go back and fix later. > what really makes me nuts is when things get triggered in headers we include… Yes, VTK seems to be really stupid about this. Still #including iostream.h or something ridiculous. -- John ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_jan _______________________________________________ Libmesh-devel mailing list Libmesh-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libmesh-devel
