Done, thanks!


On Mar 30, 2013, at 5:22 PM, "Derek Gaston" 
<fried...@gmail.com<mailto:fried...@gmail.com>> wrote:

ok - just put up the pull request - I can verify that our main test suite runs 
with it.

Derek


On Sat, Mar 30, 2013 at 3:32 PM, Derek Gaston 
<fried...@gmail.com<mailto:fried...@gmail.com>> wrote:
Sure - give me a minute...

Derek


On Sat, Mar 30, 2013 at 3:26 PM, Kirk, Benjamin (JSC-EG311) 
<benjamin.kir...@nasa.gov<mailto:benjamin.kir...@nasa.gov>> wrote:
Can you try the fix?  I outlined it in the pull request notes - basically a 
shim with the old name that calls a different new name function with 
Type=Number?

-Ben



On Mar 30, 2013, at 4:21 PM, "Derek Gaston" 
<fried...@gmail.com<mailto:fried...@gmail.com>> wrote:

Whoa - not sure what happened there... that should read:

"Do you want me to actually revert it in libmesh/master or just revert it for 
myself for now?"

Derek

On Sat, Mar 30, 2013 at 3:20 PM, Derek Gaston 
<fried...@gmail.com<mailto:fried...@gmail.com>> wrote:
Do you want me to revert actual revert it in libmesh/master or just revert it 
for myself for now?

Derek


On Sat, Mar 30, 2013 at 3:15 PM, Roy Stogner 
<royst...@ices.utexas.edu<mailto:royst...@ices.utexas.edu>> wrote:

On Sat, 30 Mar 2013, Derek Gaston wrote:

Just updated and I'm now seeing this:
  CXX      src/base/libmesh_oprof_la-dof_map_constraints.lo
In file included from src/base/dof_map_constraints.C:48:0:
./include/libmesh/system.h:1186:45: error: default template arguments may not 
be used in function templates without -std=c++11 or
-std=gnu++11
./include/libmesh/system.h:1195:64: error: default template arguments may not 
be used in function templates without -std=c++11 or
-std=gnu++11
./include/libmesh/system.h:1204:38: error: default template arguments may not 
be used in function templates without -std=c++11 or
-std=gnu++11
./include/libmesh/system.h:1607:44: error: default template arguments may not 
be used in function templates without -std=c++11 or
-std=gnu++11

Any ideas?

Looks like my backwards-compatibility fix for Manav's Real->Number
input patch only works with C++11.  Not sure why it was working in my
tests - I was likewise using a C++11-capable version of gcc without
using -std=anything.  The workaround is to do what Ben suggested:
give the templated versions of these methods new names and have the
old name just be a call to the Number version.

I can try to fix this tomorrow, but I'm not sure how easy the fix is
going to be when I can't replicate the problem.  Unless you want to
code up the fix yourself, in the meantime you could just revert that
subpatch of Manav's changes as a workaround.
---
Roy


------------------------------------------------------------------------------
Own the Future-Intel(R) Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest. Compete
for recognition, cash, and the chance to get your game on Steam.
$5K grand prize plus 10 genre and skill prizes. Submit your demo
by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net<mailto:Libmesh-devel@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/libmesh-devel


------------------------------------------------------------------------------
Own the Future-Intel(R) Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest. Compete
for recognition, cash, and the chance to get your game on Steam.
$5K grand prize plus 10 genre and skill prizes. Submit your demo
by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net<mailto:Libmesh-devel@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/libmesh-devel
------------------------------------------------------------------------------
Own the Future-Intel(R) Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest. Compete 
for recognition, cash, and the chance to get your game on Steam. 
$5K grand prize plus 10 genre and skill prizes. Submit your demo 
by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel

Reply via email to