Dmitry Karpeyev <karp...@mcs.anl.gov> writes: > In this particular instance (libMesh) it's a libMesh macro. libMesh doesn't > rely on petscversion.h, > but rather detects the petsc version numbers during configure. It doesn't > use PETSC_VERSION_RELEASE, > so it's not an entirely trivial fix (at least for me). > I build libmesh against petsc-master fairly regularly, but I don't know how > much general interest there is > in this. I'm forwarding this to libmesh-devel just in case.
When I made PETSC_VERSION_LT() regard PETSC_VERSION_RELEASE==1 as +Infinity for comparison purposes, I asked the libmesh folks (and others) if they thought that was a good idea. I still think it is. Meanwhile, libmesh could include a simple header that included petscversion.h and used #if !defined(PETSC_VERSION_LT) # define PETSC_VERSION_LT(major,minor,subminor) ... #endif I suggest this or something similar, rather than having crazy macro conditions.
pgpD9C_T4zwrd.pgp
Description: PGP signature
------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________ Libmesh-devel mailing list Libmesh-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libmesh-devel
