On Wed, Mar 11, 2015 at 1:31 PM, Roy Stogner <royst...@ices.utexas.edu>
wrote:
>
> On Wed, 11 Mar 2015, David Knezevic wrote:
>
> Changing "200" to "250" in:
>>
>> if (!is_planar_xy)
>> _tree = new Trees::OctTree (this->_mesh, 250, _build_type);
>>
>> works for me. Would you be happy with a "hacky" fix like that in the
>> short term? Or would you prefer to keep the code as-is until we have
>> a more thorough fix?
>>
>
> I'm not happy with the fix, but I'm definitely not happy with the
> current code either.
>
> Turn it from a magic number into a user-exposed parameter, and I'm
> satisfied. Go ahead and default the new parameter to 250 unless
> anyone objects.
>
OK. Yeah, the current code has a bunch of magic numbers in it. At least
this will be a (small) improvement on that.
I'll make a PR using this approach.
Thanks,
David
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel
