Yeah - definitely egg on my face. There were so many different versions
that I just screwed up the final one.
I'll put in a PR to fix it.
The weird thing is... I know that I ran tests on this version... and it
worked fine. Must have just gotten lucky (a few million times).
Derek
On Wed, Mar 30, 2016 at 12:07 PM Cody Permann <codyperm...@gmail.com> wrote:
> We aren't building C++11 yet on the build boxes so I guess that's why it
> appears fine. Also, our users are still defaulting to C++03 so yeah, nobody
> would be hitting this bug except for devs and we don't exercise threading
> too often in our day to day work.
>
> On Wed, Mar 30, 2016 at 10:01 AM Derek Gaston <fried...@gmail.com> wrote:
>
>> Ummm... guys... is it just me... or did I _completely_ cock up the
>> double-checked lock I put into PetscVector?
>>
>> Just look at where the damn lock is! It's inside the second `if`!!
>> That's not going to work!
>>
>>
>> https://github.com/libMesh/libmesh/blob/master/src/numerics/petsc_vector.C#L1331
>>
>> We had so many iterations on this... how did the final version go in like
>> this? I blame jwpeterson... since he merged it!
>>
>> Luckily... we also put in the draconian version for non-C++11... that one
>> is fine ;-)
>>
>
>> ------------------------------------------------------------------------------
>> Transform Data into Opportunity.
>> Accelerate data analysis in your applications with
>> Intel Data Analytics Acceleration Library.
>> Click to learn more.
>> http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140
>> _______________________________________________
>> Libmesh-devel mailing list
>> Libmesh-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/libmesh-devel
>>
>
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel
