Cc'ing back to libmesh-users - if we're going to start a thread with
the discovery that I broke some code, I at least want it on public
record that I undid the damage too. ;-)
---
Roy
---------- Forwarded message ----------
Date: Fri, 16 Apr 2010 19:28:37 -0500
From: Andrea Hawkins <[email protected]>
To: Roy Stogner <[email protected]>
Subject: Re: [Libmesh-users] exact_error_estimator
Awesome. It seems to be working as expected now.
Thanks!
Andrea
On Fri, Apr 16, 2010 at 6:46 PM, Roy Stogner <[email protected]> wrote:
On Fri, 16 Apr 2010, Andrea Hawkins wrote:
I believe that the exact_error_estimator.estimate_error function has a
bug in it, or at least I don't understand the current idea of the
function. It has an outer loop for the variables and an inner loop for
the elements. For each variable it seems to do as expected. However,
the error_per_cell is essentially getting overwritten for each new
variable.
Yes - it looks like I introduced a bug during an old refactoring of
this method, then never noticed because I'd only been using this
estimator on single-variable benchmarks. Thanks for catching it!
It should now be fixed (= -> +=, plus a slightly more complicated fix
for the computation of parent cell errors). Please check it out?
Thanks,
---
Roy
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Libmesh-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libmesh-users
