On Fri, 17 Sep 2010, Roy Stogner wrote: > On Fri, 17 Sep 2010, Tim Kroeger wrote: > >> Thank you for this hint. Using this, it was easy to find the point where >> the macro is not called. It's in libMesh, however, that is in >> petsc_preconditioner.C, line 49. Actually, in that file, a lot of calls to >> CHKERRABORT() are missing. Roy, is there any reason for this? > > Derek's lazy? ;-) > >> If not, I would like to add all these calls. > > Thanks!
Did this now, but I wonder whether CHKERRABORT() is really the best thing to do. I guess that, at least in methods that are handed as call-back functions to PETSc, CHKERRQ() would be the better choice, but that would also require passing the error code from PetscPreconditioner::apply() back to __libmesh_petsc_preconditioner_apply(). Well, essentially that isn't a problem either, other than that I already have a modified version of the file where __libmesh_petsc_preconditioner_apply() is implemented in, due to my subset stuff, and I don't want to set up a second checked-out copy of libMesh. If anybody agrees that doing this would be a good thing, I might do that later, when the subset stuff is finished. Provided that I don't forget. Best Regards, Tim -- Dr. Tim Kroeger CeVis -- Center of Complex Systems and Visualization University of Bremen [email protected] Universitaetsallee 29 [email protected] D-28359 Bremen Phone +49-421-218-7710 Germany Fax +49-421-218-4236 ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ Libmesh-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libmesh-users
