On Thu, 28 Feb 2013, Manav Bhatia wrote: > I wanted to run this by the developers to see if this might be an > unintended behavior: > > Lines 419 in newton_solver.cpp sets the steplength to 1.0, line 420 makes > a call to line_search which returns the value of step length. However, > there is no lvalue speficied to the call to line search, so that steplength > remain 1.0. > > I think the call to line_search should be > > Real steplength = this->line_search(.....);
This is embarrassing. As best as I can tell from "svn blame", I committed that bug (a change which ironically enough was being used for debugging purposes) along with the change set I'd been debugging. It looks like we are properly modifying the newton_iterate in line_search itself, though, and the later norm_delta multiplications and divisions by step_length cancel out, so this is only ruining the norm_delta printing in verbose mode? I'll revert it immediately; thank you for catching this! --- Roy ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ Libmesh-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libmesh-users
