:-) Yes, leisurely reading of libMesh qualifies as my weekend relaxing activity. :-)
Well, I was actually trying to implement error-estimators using the residual-based and DWR approaches for my compressible Euler solver. For the DWR, I borrowed some code from the the patch-recovery file of libMesh and realized that this needed correction. Manav > On Dec 21, 2014, at 8:32 PM, Roy Stogner <[email protected]> wrote: > > > On Sun, 21 Dec 2014, Manav Bhatia wrote: > >> It seems like line 445 in patch_recovery_error_estimator.C, which currently >> reads >> >> >> for (unsigned int i=0; i<psi.size(); i++) >> F(i) = JxW[qp]*u_h*psi[i]; >> >> should be >> >> for (unsigned int i=0; i<psi.size(); i++) >> F(i) += JxW[qp]*u_h*psi[i]; > > It looks like you're correct. I guess we just never noticed because a > grossly misintegrated error indicator is still a half-decent error > indicator? > > This looks like my fault too; it seems to be in the refactoring I did > while adding support for additional integration norms. I'll commit > the fix now; if anyone sees something we're missing they can revert > later. > > Please tell me that you discovered this bug while you were leisurely > reading through the code and not while you were pulling your hair out > trying to figure out broken results? > --- > Roy ------------------------------------------------------------------------------ Dive into the World of Parallel Programming! The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net _______________________________________________ Libmesh-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libmesh-users
