On Mon, Jul 25, 2016 at 3:48 PM, Junchao Zhang <junchao.zh...@gmail.com> wrote:
> Hello, > I came across two typos in libmesh code as follows. The second one is > obviously a bug. > > diff --git a/include/error_estimation/error_estimator.h > b/include/error_estimation/error_estimator.h > index 997975ef..c5f8bf01 100644 > --- a/include/error_estimation/error_estimator.h > +++ b/include/error_estimation/error_estimator.h > @@ -155,7 +155,7 @@ protected: > * \p error_per_cell from each processor and combines > * them to get the global error vector. > */ > - void reduce_error (std::vector<float> & error_per_cell, > + void reduce_error (std::vector<ErrorVectorReal> & error_per_cell, > const Parallel::Communicator & comm > LIBMESH_CAN_DEFAULT_TO_COMMWORLD) const; > }; > > > diff --git a/src/mesh/mesh_refinement_flagging.C > b/src/mesh/mesh_refinement_flagging.C > index fa8cc9d6..7900a08e 100644 > --- a/src/mesh/mesh_refinement_flagging.C > +++ b/src/mesh/mesh_refinement_flagging.C > > @@ -481,7 +481,8 @@ void MeshRefinement::flag_elements_by_elem_fraction > (const ErrorVector & error_p > libmesh_assert_less_equal (_coarsen_fraction, 1); > > // The number of active elements in the mesh > - const dof_id_type n_active_elem = _mesh.n_elem(); > + const dof_id_type n_active_elem = _mesh.n_active_elem(); > Thanks, these are testing over in https://github.com/libMesh/libmesh/pull/1040. Copying patches out of the body of email doesn't work that well (the second chunk was corrupted for me for some reason) but it's no big deal for 1-liners. For anything longer, please consider using "git format-patch" or, even better, creating a PR. This will also ensure that the author metadata for your patches is correct. -- John ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports.http://sdm.link/zohodev2dev _______________________________________________ Libmesh-users mailing list Libmesh-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libmesh-users
