On Tue, Apr 01, 2008 at 08:49:21PM +0200, Diego Biurrun wrote:
> @@ -622,6 +622,7 @@
> if (!(mpeg2dec->sequence.flags & SEQ_FLAG_PROGRESSIVE_SEQUENCE)) {
> picture->nb_fields = (buffer[3] & 2) ? 3 : 2;
> flags |= (buffer[3] & 128) ? PIC_FLAG_TOP_FIELD_FIRST : 0;
> + flags |= (buffer[3] & 2) ? PIC_FLAG_REPEAT_FIRST_FIELD : 0;
> } else
> picture->nb_fields = (buffer[3]&2) ? ((buffer[3]&128) ? 6 : 4) : 2;
> break;
FYI, the reason there was formerly no such exported flag was that
I considered it redundant with the picture->nb_fields information.
I suppose the extra flag does not hurt, but I do consider it very
weird why you'd want the information in a raw flag (with rather complex
and weird semantics) rather than just take the decoded version as a
number of fields. Seems to me 99% of people who want to look at the flag
will only consider the '3 fields' and '2 fields' cases, where they could
implement all cases easily if they just used the nb_fields information.
--
Michel Lespinasse
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Register now and save $200. Hurry, offer ends at 11:59 p.m.,
Monday, April 7! Use priority code J8TLD2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Libmpeg2-devel mailing list
Libmpeg2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmpeg2-devel
