Hi Diego,
> Here's a patch that fixes a number of warnings triggered by uncommon
> > GCC switches such as -Wshadow and -Wwrite-strings.
Splitting the patchset makes it easier to do a bisect for searching regressions. However, the patchset is small, and since all chunks but possibly two (the fixes for signed/unsigned mismatches in conditional operators) are no-ops, I didn't feel that splitting the patch was really necessary :)You will likely have more luck if you split this patchset. There are fixes for multiple issues in it, some of which might not be acceptable.
I have split the patch in 3 parts.
> --- a/trunk/libmpeg2/alloc.c > +++ b/trunk/libmpeg2/alloc.c > @@ -62,9 +62,9 @@ void mpeg2_free (void * buf)> > -void mpeg2_malloc_hooks (void * malloc (unsigned, mpeg2_alloc_t),> +void mpeg2_malloc_hooks (void * _malloc (unsigned, mpeg2_alloc_t), Identifiers starting with __ or _ and capitals are reserved for the system. Those starting with _ are still reserved at the file level.
> So this name is not good, I would say you should try to come up with
Yeah, now I remember about your patch that renamed identifiers starting with _ ...something else.
I changed the offending names to 'malloc_func' and 'free_func'. Regards, Lionel.
warning_fixes.tar.bz2
Description: Binary data
------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________ Libmpeg2-devel mailing list Libmpeg2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libmpeg2-devel
