On Fri, Apr 22, 2016 at 6:38 PM, Fabiano Fidêncio <fabi...@fidencio.org> wrote: > On Fri, Apr 22, 2016 at 2:56 PM, Zeeshan Ali (Khattak) > <zeesha...@gnome.org> wrote: >> Hi Fabiano, >> >> Details should go into description and shortlog should ideally be a 50 >> character summary. > > Here we don't agree that much. "(based on isodata info)" is an import > fact for this commit and not just a detail.
I didn't say it is not important detail, but it's still a detail. The fact that you had to write it in brackets, already tells you that. > Whether it exceeds 50 chars, well, that's a detail. :-) It's good to follow conventions whenever possible and in this case they are very much so, so please do. _______________________________________________ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
