On Sat, 04 May 2013, Avneet Kaur wrote: > I am Avneet Kaur, student of Bachelor of Engineering(CSE). I proposed > project "LibreDWG Decode Refectoring" in GSOC that suits my interests and > skills. > > Please review my proposal and give your views. > > http://www.google-melange.com/gsoc/proposal/review/google/gsoc2013/avneet/16001
My comments: I like it, although I think there's time for doing more during the summer. Splitting the files won't take much time, and refactoring doesn't make sense when most functionality is incomplete. To be honest, a long time after proposing this on the GSoC wiki I'm not totally sure about splitting into a few files. R_2004 and R_2007 support are not fully implemented, although the grounds for it are almost done. Maybe you could change your proposal and add those points. I would propose: finish R_2004 support -> refactor -> implement R_2007 -> (if there's still time) implement R_2010 which is very very similar to R_2007. Also, the R_2004 and R_2007 decode functions are much better than the R13/R14/R2000 one. Maybe there's a half way done. Second, if by Simian you mean this[0], you shouldn't use it within this project. It is non-free software, and we shouldn't promote it. Third, please refactor your proposal structure to follow the GNU guidelines for GSoC projects[1]. Fourth, and most importantly, rename your proposal to LibreDWG - Decode Refactoring instead of just "Decode Refactoring". I couldn't find it the first time I looked for LibreDWG proposals. There are ~50 proposals within GNU for different projects. I think you are qualified, but please improve the focus of your proposal. [0] http://www.harukizaemon.com/simian/index.html [1] http://www.gnu.org/software/soc-projects/guidelines.html happy hacking, -- Rodrigo Rodrigues da Silva http://metamaquina.com.br http://garoa.net.br http://polignu.org http://gnu.org
