Just look any accessor function in src/dwg_api.c; they lack return statements for the "undefined" case.
Let's take dwg_ent_lwpline_get_elevation if(lwpline == 0), then the return value of the function is undefined behaviour. I recommend returning NaN in this case. The root problem is, people will be lazy and check the error parameter passed in. I don't even agree with this error pattern but at this point it's no reason to change all your hard work. There is a lot of great stuff in this project and the current problem with it is not how the API functions are organized, but a lack of attention to the basics (especially the realloc problem...) On Thu, May 15, 2014 at 8:57 AM, gagan <[email protected]> wrote: > On Thu, May 15, 2014 at 3:37 AM, Dave Bender <[email protected]> wrote: > > You should compile with warnings and add the missing return statements to > > those functions > > Missing return statements to which functions? > > -- > Thanks > Gaganjyot > "Jai Sai Naath" > >
