https://bugs.freedesktop.org/show_bug.cgi?id=32347
--- Comment #13 from Lionel Elie Mamane <[email protected]> 2011-11-23 05:26:04 PST --- !!!! Bugzilla lost my carefully crafted comment :-( So starting again, but "it was not as good" as she said: Need intervention / advice from Windows porter (Tor?). The immediate cause is that _ADO_DATALINK_BROWSE_ is not #define'd in dbaccess/source/ui/dlg/ConnectionHelper.cxx. There used to be this code: #if !defined(WINDOWS_VISTA_PSDK) && defined(WNT) #define _ADO_DATALINK_BROWSE_ #endif This explains why OpenOffice 3.3rc1 did not have this bug (compiled with WIndows XP SDK), but LibreOffice 3.3rc1 had this bug (compiled with Windows Vista SDK). The tinderbox build logs tell me that adodatalinks.cxx is compiled alright now, so my guess is that this whole "disable ADO if compiling with Vista SDK" is obsolete by now. Could a Windows porter just remove all that logic (basically finishing Tor's cleanup job in 4c505502a86f8579711ef869e171f7bcce35f7eb) and test? Thanks in advance. #define _ADO_DATALINK_BROWSE_ in dbaccess/source/ui/dlg/ConnectionHelper.cxx Remove all DISABLE_ADO and WINDOWS_VISTA_PSDK logic from dbaccess/Library_dbui.mk and dbaccess/Library_dbu.mk Compile, test, report. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
