https://bugs.documentfoundation.org/show_bug.cgi?id=159874
Julien Nabet <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|[email protected] |[email protected] |desktop.org | Status|NEW |ASSIGNED --- Comment #3 from Julien Nabet <[email protected]> --- I've submitted a minimal patch here: https://gerrit.libreoffice.org/c/core/+/163903 but here are what I put in the commit: " - there are TextureKind.idl and TextureKind2.idl but first one is indicated as deprecated since 2000! (see 4f9e6d84feb36ab3072dafbab0ba4ae46d264f9b #80594# added a new TextureKind2 enum because of missing value in TextureKind) => should we only use TextureKind2.idl now? - in svx/source/sdr/primitive3d/sdrattributecreator3d.cxx, we can read this comment: // TextureKind: 1 == Base3DTextureLuminance, 2 == Base3DTextureIntensity, 3 == Base3DTextureColor See https://opengrok.libreoffice.org/xref/core/svx/source/sdr/primitive3d/sdrattributecreator3d.cxx?r=05416682#88 but TextureKind2.idl defines LUMINANCE, INTENSITY and COLOR with no number, so I expect they take by default values 0, 1 and 2 See https://opengrok.libreoffice.org/xref/core/offapi/com/sun/star/drawing/TextureKind2.idl?r=5687eba4 BTW, same pb with this line: // TextureMode: 1 == Base3DTextureReplace, 2 == Base3DTextureModulate, 3 == Base3DTextureBlend TextureMode.idl just indicates: REPLACE, MODULATE and BLEND => should we change comments and related code? " If someone has some thoughts here... -- You are receiving this mail because: You are the assignee for the bug.
