https://bugs.documentfoundation.org/show_bug.cgi?id=160094

--- Comment #6 from Julien Nabet <[email protected]> ---
There are 2 main parts which rely on RTL/LTR layout in
sd/source/console/PresenterToolBar.cxx:
1) in PresenterToolBar::Layout line 747
2) in PresenterToolBar::LayoutPart line 846

I thought that instead of 2 different treatments, perhaps we may just use a
reversed vector.
"maElementContainer" is defined as "ElementContainer" which is a typedef of
::std::vector<SharedElementContainerPart>.

For 1) it does the trick.

For 2) we do "for (auto& rxElement : *rpPart)"
rpPart is "SharedElementContainerPart" which is defined as
"std::shared_ptr<ElementContainerPart>"
so *rpPart is "ElementContainerPart".
This last one is defined as "class PresenterToolBar::ElementContainerPart
    : public ::std::vector<rtl::Reference<Element> >"

I tried to simplify this by creating a new typedef as:
typedef ::std::vector<rtl::Reference<Element> > ElementContainerPart;

but it doesn't know "Element" in sd/source/console/PresenterToolBar.hxx.

IMHO, there are a lot of things defined in
sd/source/console/PresenterToolBar.cxx which should be in
sd/source/console/PresenterToolBar.hxx
but I got lost with namespaces uses, I didn't succeed in building LO with this
refactoring.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to