https://bugs.documentfoundation.org/show_bug.cgi?id=154715

Caolán McNamara <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #11 from Caolán McNamara <[email protected]> ---
I think what the bisect identified is the commit that restored the ability of
this dialog to read the previous saved settings used in that page.

What I think is then funky is that the page has "IsFieldEdit" which
distinguishes between the page used to edit a field, vs the other case when its
for inserting a field.

But even if "IsFieldEdit" is set, then it uses the saved settings to restore
the last used settings. What is particularly off is

https://cgit.freedesktop.org/libreoffice/core/tree/sw/source/ui/fldui/fldref.cxx#n270

where we have: if( !IsRefresh() ) used twice, one inside the other, but if was
true in the outer use, it would be true in the inner (all the way back to the
initial commit). And IsRefresh is only true I think for the case of using the
"next/back" button to go to edit another field.

Which suggests that if you click next and then back that you then get the right
results

I think one of those IsRefresh was intended to be IsFieldEdit

https://gerrit.libreoffice.org/c/core/+/165876

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to