https://bugs.documentfoundation.org/show_bug.cgi?id=160469
Buovjaga <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Buovjaga <[email protected]> --- Noel helped me in the chat. The reserved key codes are defined here: https://opengrok.libreoffice.org/xref/core/vcl/source/app/svapp.cxx?r=324f2e13#98 Doing git log -S"KEY_F4,KEY_MOD1|KEY_MOD2" vcl/source/app/svapp.cxx we find the commit adding them is 2c3de6e3bf79a7bd5c8b09f06359de610d2ef7dc from 2002, "keycodes handled internally by VCL" (LibreOffice's graphics/UI toolkit). There we see the comment "dock/undock" associated with the shortcut. A couple of days later in 14b14675e2dad1704ea307c85d562a25cd7904f5 the comment was removed in favour of the name SV_SHORTCUT_DOCKUNDOCK. The ReservedKeys array in vcl/source/app/svapp.cxx has an #ifdef UNX block. While the original reason for reserving Ctrl+Alt+F4 doesn't hold anymore, I wonder if we should reserve all the Ctrl+Alt+Fx virtual console shortcuts on UNX? Certainly the ReservedKeys array needs to have comments explaining why something is reserved! -- You are receiving this mail because: You are the assignee for the bug.
