https://bugs.documentfoundation.org/show_bug.cgi?id=136339
--- Comment #7 from Glen Campbell <[email protected]> --- (In reply to Stéphane Guillou (stragu) from comment #6) > (In reply to Glen Campbell from comment #5) > > perhaps someone did > > some unrelated work that accomplished the fix here. > > could you please retest to confirm > Indeed, if both parent and child use a highlight colour, "Reset to Parent" > does work. I also see it fixed in 24.2.2.2, whereas it does not work in > 7.6.6.3. This can be tested in the sample document with e.g. "First Line > Indent", changing its highlight colour, then resetting to its parent's (Body > Text). > > However, if I follow the steps in comment 0, it is not completely fixed: the > parent (Default Paragraph Style) uses "None" in the Highlighting tab, > whereas the child (Body Text) uses a colour. Clicking "Reset to Parent" > applies a white highlight colour, which is not correct. It should change the > Highlighting from "Color" to "None". > > The relevant commit is: > > commit 167fb166e4097c4a855c08a70cdf70c19d4d87ac > author Jim Raykowski Tue Oct 17 17:21:33 2023 -0800 > committer Jim Raykowski Fri Nov 03 03:18:38 2023 +0100 > tdf#157801 Fix direct formatting is applied after pressing OK in the > Character properties dialog when the Highlighting tab Color page is > open and the color has not been changed > Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158100 > > ... which corresponds to build [642a7091b9e1e4eceaba9c350bd64f653b647845] in > linux-64-24.2 bibisect repo. > > Jim, thanks for the side-effect fix! > > Let's keep this report open as "Reset to Parent" should also change from > "Color" to "None" in this case (instead of applying a white highlight). I had an interesting conversation with [email protected] on https://bugs.documentfoundation.org/show_bug.cgi?id=135834. Should I employ the multi-step process as described there, or something else? Or is this "over-engineering"? -- You are receiving this mail because: You are the assignee for the bug.
