https://bugs.documentfoundation.org/show_bug.cgi?id=160847
Stéphane Guillou (stragu) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] See Also| |https://bugs.documentfounda | |tion.org/show_bug.cgi?id=95 | |878 Keywords| |bibisected, bisected, | |implementationError --- Comment #12 from Stéphane Guillou (stragu) <[email protected]> --- (In reply to ady from comment #11) > (In reply to Stéphane Guillou (stragu) from comment #10) > IMHO, the new wording is slightly confusing. The original wording confused two features, using "AutoInput" to describe what I call "function syntax tooltip". I renamed it to be more precise while sill describing the original observation, but changing the expectation to _always_ having the function help tooltip on, regardless of AutoInput. > I think that the original report is that, as of the current "double > function" of the AutoInput setting, when the setting is OFF then the > backspace key should not trigger the bubble tooltip auto-completion of > functions, just as any other key does not trigger the auto-completion. Fair enough, it does seem like an inconsistency. > The new wording might be interpreted as "only the backspace key is working > correctly, and other cases/keys should behave in the same way", which is > somewhat the opposite of this request, IIUC. The request in this tdf#160847 > seems to be that the backspace key should not trigger the auto-completion of > functions (just as any other key does not trigger the auto-completion > either) when AutoInput is OFF. I understood the original request to be a band-aid solution that consolidates the confusion between the two features - even if it makes things more consistent. what should really happen is that the AutoInput switch shouldn't influence the function syntax tooltip feature at all, a request that should be centralised into bug 144860. > Moreover, some users might think of the actual auto-completion as a separate > feature than the bubble: the bubble may suggest (only) but not necessarily > imply auto-complete the content as well. The difference is: AutoInput helps autocomplete based on _previous, user-entered_ data, whereas the function syntax tooltip helps understand and autocomplete formulas based on function syntax. But of course, all of the above is based on my understanding of what the features are, and I might be missing something. For good measure, I looked at where the behaviour started exactly. Bibisected with linux-64-5.2 repo to build [2f139c1caf425a18bca2e36611c5aaddc0cbc7e0] which points to: commit b2a82d9bb256516ac589350579b90f43b68bd452 author Keigo Kawamura Mon Nov 16 20:39:06 2015 +0900 committer Eike Rathke Mon Jan 18 17:42:20 2016 +0000 tdf#95878 made more useful function suggestion system in formula editing Reviewed-on: https://gerrit.libreoffice.org/20035 Before that commit, turning off AutoInput would turn off the (simple) function tooltip. After the commit, we have the inconsistency. Keigo is not active anymore, but Eike helped out with the patch and had follow-up commits. Eike, what do you think about: - this inconsistency in particular? - how the two features mix? (AutoInput vs "function syntax help tooltip") In my opinion, the two should be kept separate, and the users should be able to turn off AutoInput without turning off the function syntax tooltip. -- You are receiving this mail because: You are the assignee for the bug.
