https://bugs.documentfoundation.org/show_bug.cgi?id=161765
Bug ID: 161765
Summary: EDITING: Copying cells in Calc doesn't show marching
ants animation, neither in default configuration nor
regardless of the expert option "AnimationsEnabled",
unless the OS’s "Show animations" setting is switched
on.
Product: LibreOffice
Version: 24.2.0.0 alpha0+
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: Calc
Assignee: [email protected]
Reporter: [email protected]
Description:
Copying cells in Calc doesn't show “marching ants” animation, neither in
default configuration nor regardless of the expert option "AnimationsEnabled",
unless the OS’s "Show animations" setting is switched on.
In previous versions including 7.6.7.2 the OS’s "Show animations" setting was
disregarded.
Starting with LibreOfficeDev_24.2.0.0.alpha0/alpha1, this setting is suddenly
not only used in LibreOffice (for just the "marching ants" animation), but it
in fact overrides expert option "AnimationsEnabled" set to “true”.
Starting with LibreOfficeDev_24.2.0.0.alpha0/alpha1 , one is able to turn _off_
the "marching ants" animation in LO by using the expert setting
"AnimationsEnabled", regardless of the state of "Show animations in Windows".
However, the problem is, than one is not able to turn _on_ the "marching ants"
animation in LO by using the expert setting "AnimationsEnabled", regardless of
the state of OS’s "Show animations" setting.
For visual impaired people (e.g. elderly people), or just having bad light
conditions, the "marching ants" animation is really helpful and this helpful
feature is known from MS Excel. The OS’s "Show animations" setting turns on
_all_ animations in the OS and makes a slow computer even slower. Also for
people using Remote Desktop, having to enable _all_ animations in the OS just
for having the “marching ants” animation in LO is a bad idea.
The copied cells have not any more a "marching ants" animation copy border
starting with LibreOfficeDev_24.2.0.0.alpha0/alpha1 , but have just a "sleeping
ants" border, if the OS’s "Show animations" setting is switched off. The expert
option "AnimationsEnabled" doesn't have an effect, neither “true” nor “false”
activate the "marching ants" animation.
Note: the page break / print area also uses the same "sleeping ants" border,
which is confusing to non-experts.
There are likely very few people having to have all the OS's animation turned
on (by the OS's animation setting turned on), and then in LO to switch off the
"marching ants" animation - unless the problem is, that quite some people
didn't know about this expert setting.
Suggestion:
There should be an option to have the LO animation "Always on" or "Always off"
regardless of the OS's animation setting.
a) The default behaviour of copying cells should be the old "marching ants"
animation, when the expert setting "AnimationsEnabled" is “true”, regardless of
the state of OS’s "Show animations" setting. I do understand that there might
be people feeling annoyed by "marching ants" animation, but the option to
switch on/off the animation ("AnimationsEnabled") must be respected.
Or b)
Perhaps it would be an even better idea to have a new LO tristate-option
(perhaps "AnimationsEnabledTristate") with three alternatives: “Always on”,
“Always off” and “Use OS’s animation setting”
In any case, it needs to be documented how to switch the "marching ants"
animation on/off.
Searching in the code for "AnimationsEnabled" I found (among others):
https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/overlayobject.cxx?r=9d68c794#41
Change request:
Changing the line of code:
https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/overlayobject.cxx?r=9d68c794#41
mbAllowsAnimation = (officecfg::Office::Common::VCL::AnimationsEnabled::get()
&& !MiscSettings::GetUseReducedAnimation());
into:
mbAllowsAnimation = officecfg::Office::Common::VCL::AnimationsEnabled::get();
Expert option "AnimationsEnabled" specifically:
I changed this setting using: “Tools” -> “Options” -> “LibreOffice” ->
“Advanced” -> “Open Expert Configuration” -> Type: animat
"org.openoffice.Office.Common" -> "VCL" -> "AnimationsEnabled".
The problem occurred with the patch discussed in tdf#155414 comment 7.
https://bugs.documentfoundation.org/show_bug.cgi?id=155414#c7
It is still present in 24.2.4.2 and got introduced in 24.2.0.0.alpha0/alpha1.
However, in 7.6.7.2 the "marching ants" animation worked as usual.
Note: The bug is also present in 24.8.beta1.
Before it makes sense to change the code, how do you see the above suggestion
and change request?
Steps to Reproduce:
1. Preferable use a windows-OS, but this bug should also be present in MacOS.
2. Set the OS’s animation setting to switched _off_.
For Windows do the following:
Details for "Show animations in Windows" in "Ease of Access" setting in
WindowsOS:
(English: Windows OS -> Settings -> "Ease of Access" -> "Display" -> "Simplify
and personalise Windows" -> "Show animations in Windows")
(German: Windows OS -> Einstellungen -> "Erleichterte Bedienung" ->
"Bildschirm" -> "Windows vereinfachen und personalisieren" -> "Animationen in
Windows anzeigen")
3. At least on WindowsOS, wait up to 30 seconds for the change of the animation
setting to take effect.
4. Make sure that the OS’s animation setting is switched off and have taken
effect.
5 (If needed) Install a parallel installation of 7.6.7.2 win x86_64.
6. (If needed) Install a parallel installation of 24.2.4.2 win x86_64
7. Create a new Calc document.
8. Select a group a cells and select "Copy"
9. Repeat the tests with different setting of expert option
"AnimationsEnabled": “true”/false”.
Actual Results:
In 7.6.7.2: The copied cells have a "marching ants" animation border as usual,
regardless of the state of the OS’s animation setting.
In 24.2.4.2: The "marching ants" animation does not work: The copied cells have
a "sleeping ants" border (the same as the page break / print area). This
provided that the OS’s animation setting is switched _off_ and have taken
effect.
In 7.6.7.2: The expert option "AnimationsEnabled" gets respected: "true" means
"marching ants" animation border. "false" means "sleeping ants" border.
In 24.2.4.2: The expert option "AnimationsEnabled" gets disregarded. Both
"true" as well as "false" means "sleeping ants" border provided that the OS’s
animation setting is switched _off_ and have taken effect.
In 24.8.0.0.beta1+: The same result as in 24.2.4.2.
Testing restarting in Safe Mode with hardware acceleration turned off produced
the same result as above (with 24.2.4.2 and 24.8.0.0.beta1+)
Expected Results:
1. The default behaviour should be that the copied cells have a "marching ants"
animation as usual until and including 7.6.7.2.
2. The expert option "AnimationsEnabled" must get respected, even if the OS’s
animation setting is switched off. "AnimationsEnabled" set to "true" means
"marching ants" animation border. "false" means "Sleeping ants" border.
Reproducible: Always
User Profile Reset: Yes
Additional Info:
Details of my parallel installations of LO:
(the were freshly installed with a new user profile in:
UserInstallation=$ORIGIN/../Data/settings )
Version: 24.8.0.0.beta1+ (X86_64) / LibreOffice Community
Build ID: dcaf9c147a1cfea268db49952171338555379794
CPU threads: 4; OS: Windows 10 X86_64 (10.0 build 19045); UI render:
Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded
**********************************************************
Version: 24.2.4.2 (X86_64) / LibreOffice Community
Build ID: 51a6219feb6075d9a4c46691dcfe0cd9c4fff3c2
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded
This bug is in effect regardsless if advanced experimental features are enabled
or not.
See also the fixed bug report tdf#156506.
See also the fixed bug report tdf#155414
Before it makes sense to change the code, how do you see the above suggestion
and change request?
--
You are receiving this mail because:
You are the assignee for the bug.
