https://bugs.documentfoundation.org/show_bug.cgi?id=160992

--- Comment #3 from Ryan Landay <[email protected]> ---
I recently tried building LibreOffice for the first time and noticed that some
tests in chart2import2.cxx, specifically testTdf133376, testTdf136105, and
testTdf136752 were consistently failing:

https://paste.debian.net/1323698/

Hossein advised me in IRC that this is likely because of this bug (I’m running
macOS on a 2019 16" Retina MacBook Pro). The first two of these tests include
this check, which is not working properly on my machine:

    // FIXME: the DPI check should be removed when either (1) the test is fixed
to work with
    // non-default DPI; or (2) unit tests on Windows are made to use svp VCL
plugin.
    if (!IsDefaultDPI())
        return;

testTdf136752 is missing this check.

I spent several hours trying to figure out why this check is not working
properly. Unfortunately this was somewhat difficult given by unfamiliarity with
this codebase and I don’t currently have a fix. Here are my notes:

https://docs.google.com/document/d/1At9aFXqVLQc_k82P5Qu3E0MYd5KZpGZkHvKQAxO5Mj0/edi

I concluded:

It seems that my Mac (a 2019 16” Retina MacBook Pro) using HiDPI mode is
causing some sort of problem with the test case. However, the test harness is
calling Application::EnableBitmapRendering() and seems to be running in some
sort of headless mode where IsDefaultDPI() returns “true.”

Potential fixes:
1. Fixing the tests to run properly in HiDPI mode (preferable)
2. Fixing the headless mode to report the DPI properly
3. Changing the test harness to create a window and avoid using the logic for
the headless case

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to