https://bugs.documentfoundation.org/show_bug.cgi?id=162263

--- Comment #13 from Patrick Luby (volunteer) <[email protected]> ---
(In reply to Heiko Tietze from comment #12)
> SVG icons are rasterized depending on the DPI and we would have to create
> two sizes, if the toolbar is set to small and the sidebar to large. Tomaz,
> you know best.

So I did some debugging and verified that the sidebar icons are using the same
fix for SVG icons that I implemented for the toolbar icons: the SVG icon is
rasterized to a bitmap that is 2x width and height.

How the fix for the toolbar SVG icons works is that the toolbar SVG icons are
rasterized to "double sized" bitmaps and then drawn directly to a drawing
surface to half the width and height. Since on macOS drawing surfaces hold 4
pixels for every one pixel, drawing a bitmap at half its width and height
preserves all of the pixels in a "double sized" bitmap.

I would expect that the same behavior would occur with the sidebar SVG icons.
But, unlike the toolbar icons, the "double sized" bitmap looks like it is
downscaled back to half width and height somewhere *before* drawing. The
LibreOffice code really doesn't handle the "macOS has 4 (really 2x2) pixels per
pixel" behavior as it is unique to macOS.

So, I think my next step is to try to find where LibreOffice is downscaling
sidebar icons before drawing. In other words, the "double sized" bitmap should
be used to draw the icon but it looks like what is drawn is a downscaled copy
of the "double sized" bitmap.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to