https://bugs.documentfoundation.org/show_bug.cgi?id=106137

Mike Kaganski <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |difficultyMedium, easyHack,
                   |                            |skillCpp

--- Comment #13 from Mike Kaganski <[email protected]> ---
This is rather straightforward: grep the codebase for places that make use of
i18nutil::SearchOptions2::replaceString, and in those cases where this string
is used to replace something, and the mode is regex, pre-process it to replace
the \uhhhh and \Uhhhhhhhh with their Unicode counterpart strings (mind that the
replacement can be not a single character!). This should be implemented as a
function in i18nutil; it must take comment 3; and it must take care of the
usual escaping (note comment 5, and take a look how currently the replacement
works for a regex in Writer with \t and \\t as replacement string).

Where possible, this replacement should be done once, when a function actually
doing the search would get the replacement string for the first time. Where not
easy, due to the actual algorithm, this optimization can be left for a
follow-up.

Indeed, the fixes need to be modular - no need to do it at once for all
mosules. A commit adding the function to process the replacement string; a
commit to introduce it to Writer; then to calc, etc.

All commits need to have unit tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to