https://bugs.documentfoundation.org/show_bug.cgi?id=163215
--- Comment #6 from Jonathan Clark <jonat...@libreoffice.org> --- (In reply to خالد حسني from comment #5) > I’m not very up to date with the Kashida code, but I was thinking of > something simpler, like in > https://git.libreoffice.org/core/+/refs/heads/master/vcl/source/gdi/ > CommonSalLayout.cxx#687 always set GlyphItemFlags::IS_SAFE_TO_INSERT_KASHIDA > flag if the font has AAT substitutions, so that down stream code does not > require any changes. Since Jonathan Clark is actively working on this code, > he is more suited to give an opinion here. In my opinion: - Flag all glyphs as safe to insert kashida, as suggested here. - Update OutputDevice::GetWordKashidaPositions (vcl/source/outdev/font.cxx:1218) to leave the position vector empty for AAT fonts. - Update the fallback rule 8 (i18nutil/source/utility/kashida.cxx:297) to require a non-empty pValidPositions vector. We can't rely on VCL to filter out invalid positions for AAT fonts, so this fallback is not a safe default anymore. It shouldn't be necessary to change any code in sw or editeng. -- You are receiving this mail because: You are the assignee for the bug.
