https://bugs.documentfoundation.org/show_bug.cgi?id=162666
BogdanB <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|bibisectRequest |bibisected --- Comment #9 from BogdanB <[email protected]> --- Was so easy to bibisect: I am getting the same: author Armin Le Grand (allotropia) <[email protected]> 2024-01-22 19:18:32 +0100 committer Armin Le Grand <[email protected]> 2024-01-23 10:30:59 +0100 commit 38072fd7eb7d53237efbe0d8bacc7db1c4f3131c (patch) tree f46f20f947a37013fb0539ff235216bae149d443 parent db4cb7cee82615973d1be9fd631c1317f1da5820 (diff) ITEM: Solve SfxVoidItem(0) situation An instance of SfxVoidItem(0) was used to signal the SfxItemState::DISABLED. This was done not only using WhichID == 0, but using isVoidItem() at the SfxPoolItem. Unfortunately this mixes up with usages of SfxVoidItems, mostly for UI stuff/Slots. This also means that all the time an SfxVoidItem had to be cloned/delete when when added/removed from ItemSet or ItemHolder. Much more action than e.g. for INVALID_POOL_ITEM which we already use by havong just a simple ptr to a single static instance of an Item. Disabled should do the same thing. Unfortunately also the functionality was mixed with non-SfxItemState::DISABLED purposes and these were very hard to be separated. But the current solution works now after some quirks doing that. It even oes no more need the isVoidItem() flag at the SfxPoolItem. Change-Id: I99f03db144f541ae4ea35f3775b3b3d58a375a81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162414 Tested-by: Jenkins Reviewed-by: Armin Le Grand <[email protected]> cad5a2eca916806372f476b380bd34e7d3f388b1 is the first bad commit commit cad5a2eca916806372f476b380bd34e7d3f388b1 Author: Jenkins Build User <[email protected]> Date: Fri Jan 26 09:21:24 2024 +0100 source sha:38072fd7eb7d53237efbe0d8bacc7db1c4f3131c source sha:38072fd7eb7d53237efbe0d8bacc7db1c4f3131c instdir/program/libbasctllo.so | Bin 2368240 -> 2368256 bytes instdir/program/libchartcontrollerlo.so | Bin 4327496 -> 4327440 bytes instdir/program/libcuilo.so | Bin 5784832 -> 5784776 bytes instdir/program/libeditenglo.so | Bin 3583472 -> 3583480 bytes instdir/program/libfrmlo.so | Bin 4848344 -> 4848352 bytes instdir/program/libmsfilterlo.so | Bin 1117208 -> 1117208 bytes instdir/program/libmswordlo.so | Bin 3456928 -> 3456928 bytes instdir/program/libpcrlo.so | Bin 2319280 -> 2319224 bytes instdir/program/librptuilo.so | Bin 1972792 -> 1972792 bytes instdir/program/libscfiltlo.so | Bin 6966232 -> 6966232 bytes instdir/program/libsclo.so | Bin 25009576 -> 25009488 bytes instdir/program/libscuilo.so | Bin 1138384 -> 1138384 bytes instdir/program/libsdlo.so | Bin 11562488 -> 11566528 bytes instdir/program/libsduilo.so | Bin 2363400 -> 2363408 bytes instdir/program/libsfxlo.so | Bin 8802120 -> 8801944 bytes instdir/program/libsmlo.so | Bin 3000144 -> 3000152 bytes instdir/program/libsvllo.so | Bin 3450672 -> 3450672 bytes instdir/program/libsvxcorelo.so | Bin 13577296 -> 13577240 bytes instdir/program/libsvxlo.so | Bin 6089816 -> 6089760 bytes instdir/program/libswlo.so | Bin 26091672 -> 26091624 bytes instdir/program/libswuilo.so | Bin 3401856 -> 3401856 bytes instdir/program/setuprc | 2 +- instdir/program/versionrc | 2 +- 23 files changed, 2 insertions(+), 2 deletions(-) -- You are receiving this mail because: You are the assignee for the bug.
