https://bugs.documentfoundation.org/show_bug.cgi?id=163404
--- Comment #3 from Julien Nabet <[email protected]> --- (In reply to vibrationoflife from comment #2) > Ok I pushed the my changes: https://gerrit.libreoffice.org/c/core/+/174877 > > I alsoe added comments to the method as follows: > > com.sun.star.deployment.thePackageManagerFactory is deprecated. ... Thank you for the quick feedback! Your patch mixes the fix and some reformatting. In order to pinpoint regression more easily, it's better to have 2 patches in this case. The simplest way would be here to: 1) synchronize your local sources with master branch 2) do the fix on local (just the fix, not reformatting or anything else) 3) submit the patch with the appropriate message: tdf#163404: Update getPackageName2PathMap to use ExtensionManager ...instead of the deprecated thePackageManagerFactory. Then once the patch will be pushed on master 4) Change the comment of https://gerrit.libreoffice.org/c/core/+/174877 to put: Reformatting with "black" no functional change 5) Rebase the patch BTW, don't forget the license statement if you haven't sent it yet. (see https://wiki.documentfoundation.org/Development/GetInvolved#License_statement). (I don't see it on https://lists.freedesktop.org/archives/libreoffice/2024-October/) -- You are receiving this mail because: You are the assignee for the bug.
