https://bugs.documentfoundation.org/show_bug.cgi?id=163520
--- Comment #7 from Eyal Rozenberg <[email protected]> --- (In reply to Jonathan Clark from comment #5) I would say that if you're ok with top-aligned multi-line placement, then you should support "mirroring" this behavior for bottom-aligned, i.e. start with the line gap at the bottom, then the bottom line, then a line gap, then the next line etc; and for vertical-middle alignment - do the middle between the two, which means half line-gap above and below, then a sequence of (ascender-descender), full line-gap, (ascender-descender) etc. Also - why would you expect a single line not to have a ling gap above it, but the same line to have the line gap just because there's another line beneath? I mean, I know you said it's subjective, but can you try elaborating on the intuition in favor of that? ------------------- Side-comments: > One thing to keep in mind is, if your goal is to make this "look right", a > closed-form solution will never be adequate. What "looks right" is ... > Even if font authors could provide a tuned metric for vertical centering, > it would look just as wrong in many situations as what we currently do. That's a fair point. But a better formula could get us from appearing "way off" to "decent" in a lot more cases. (Plus, we could eventually go as far as a heuristic based on the actual text content, e.g. do something different for all-lowercase text rather than some-uppercase, or with tanween above but not below and vice-versa.) > I confirm that the vertical positioning of top- and middle-anchored text is > based on line height, rather than just font ascent and descent. So, relating back to Regina's comment - it seems that our highlighting also uses the line height rather than the font metrics. > This is > difficult to see with text metrics alone, but can be easily demonstrated by > changing the line spacing in the shape style. ... well, that breaks the highlighting analogy thoug. Perhaps highlighting height is "line height with single spacing" rather than "line height with the currently-defined line spacing". -- You are receiving this mail because: You are the assignee for the bug.
