https://bugs.documentfoundation.org/show_bug.cgi?id=163772
Bug ID: 163772
Summary: Importing an icon for a toolbar command does an
unwanted change to the icon grid
Product: LibreOffice
Version: 6.3.0.4 release
Hardware: x86-64 (AMD64)
OS: All
Status: UNCONFIRMED
Keywords: bibisected, bisected, regression
Severity: minor
Priority: medium
Component: UI
Assignee: [email protected]
Reporter: [email protected]
Created attachment 197415
--> https://bugs.documentfoundation.org/attachment.cgi?id=197415&action=edit
24x24 icon for testing
1. Open Writer (for example)
2. Tools - Customize - Toolbars
3. Select a command in Assigned Commands
4. Click Modify - Change Icon
5. Click Import and select a bitmap
Repeat step 5 several times, replacing the same bitmap.
With gtk3, the whole dialog will grow each time, with the individual icon
images themselves also growing. With qt-based UIs, gen and Windows, the dialog
will not grow and the icon grid will move down and to the right.
The icon selector dialog was welded in
91548e11b37f52aed476996d7d97ad2b45e43ed5. Back then, these unwanted changes did
not yet happen. They started with c9956772ec0678498515fb60dca41e9a77457f86
Resolves: tdf#124809 spacing ignored unless WB_ITEMBORDER is set
Looking at the changes, reading the code and debugging, it seems the
ValueSet::Format function in svtools/source/control/valueset.cxx is the thing
doing the work here. If I put a breakpoint into the line that is said to
"calculate item offset", `if (nStyle & WB_ITEMBORDER)`, after importing I hit
the breakpoint twice and the unwanted change happens after the first hit.
While this happens not only when replacing, if you use replacing in the dialog,
the relevant dialog code is in SvxIconSelectorDialog::ReplaceGraphicItem of
cui/source/customize/cfg.cxx
What is the route from SvxIconSelectorDialog::ReplaceGraphicItem to
ValueSet::Format I'm not exactly sure. I suppose it goes through
ValueSet::QueueReformat in valueset.cxx
--
You are receiving this mail because:
You are the assignee for the bug.
