https://bugs.documentfoundation.org/show_bug.cgi?id=163824
Justin L <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|[email protected] |[email protected] |desktop.org | --- Comment #3 from Justin L <[email protected]> --- The only thing I can think of is to move the save into DeactivatePage. OR else to call DeactivatePage on cancel and extend enum class DeactivateRC to call back a new DialogClosing function. OR else to extend SfxOkDialogController to request a call-back on dialog close. (In reply to Justin L from comment #2) > likely a failure of IMPL_LINK_NOARG(SfxTabDialogController, CancelHdl) > which does not PrepareLeaveCurrentPage(). Better in this case would be to simply call DeactivatePage(nullptr). It has always been like this since initial implementation with commit 28fc0962b10519ab84654d189d2ad0cca8f84f95 Author: Caolán McNamara on Tue Apr 24 14:14:34 2018 +0100 weld SwLabDlg The impact of using DeactivatePage is that this would avoid saving on a CANCEL (which could make sense to me) - although that could be worked around simply by first moving to a different tab/page before cancelling. Ahh - actually the Destructor works very nicely. -- You are receiving this mail because: You are the assignee for the bug.
