https://bugs.documentfoundation.org/show_bug.cgi?id=128186

--- Comment #6 from Patrick (volunteer) <[email protected]> ---
While fixing tdf#161623, I read through the more recent descriptions of
problems that Tor encountered in the previous attempt to implement native full
screen mode and I think my fix for tdf#161623 also fixes the following two past
problems. Hopefully, further testing won't prove me wrong:

Closing a native full screen window
-----------------------------------

I also ran this problem when I implemented native full screen windows in
NeoOffice. Through frantic trial and error, I found that you can't call
-[NSWindow orderOut:] to hide a window while it is in native full screen mode.
You must call -[NSWindow close]. Who knows why. Probably just a quirky macOS
bug.

LibreOffice vs. native full screen mode
---------------------------------------

>From what I understand, Tor was trying to implement automatically switching
into  LibreOffice full screen mode when a document entered native full screen
mode. In NeoOffice, I never figured how to make LibreOffice full screen mode
work in native full screen mode so IIRC (it was over a decade ago so my memory
is hazy) I added a hack somewhere to override the View > Full Screen menu and
just force the native window into native full screen mode. Basically I did what
Tor recommended: remove LibreOffice's full screen mode (at least on macOS).

But I took another look at the vcl portion of the LibreOffice full screen code
and, at the macOS level, and it wasn't doing much different that native full
screen mode other than hiding/showing the menubar and the Dock. Most of the
LibreOffice full screen mode stuff is within the window and is handled by the
LibreOffice in the Writer and Calc code so no problem keeping that. Most of
this problem was in the code that hides and shows the menubar and the Dock.
Once I figured out that unexpected things happen when hiding the menubar in
native full screen mode, LibreOffice full screen mode now works within a native
full screen window.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to