https://bugs.documentfoundation.org/show_bug.cgi?id=164685

Rafael Lima <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #2 from Rafael Lima <[email protected]> ---
Hi Armin,

I'm looking into this... I created a Python script using regex to make all the
substitutions and it works around 90% of the times.

However, I came across a few lines where we have unique pointers such as:

In: sc/source/ui/drawfunc/drawsh.cxx

auto xItemSet = std::make_unique<SfxItemSetFixed<SID_ATTR_MACROITEM,
SID_ATTR_MACROITEM, SID_EVENTCONFIG, SID_EVENTCONFIG>>( SfxGetpApp()->GetPool()
);

What is the best approach to deal with these cases? This is how I'm doing the
conversion:

std::unique_ptr<SfxItemSet> xItemSet =
std::make_unique<SfxItemSet>(SfxItemSet::makeFixedSfxItemSet<SID_ATTR_MACROITEM,
SID_ATTR_MACROITEM, SID_EVENTCONFIG,
SID_EVENTCONFIG>(SfxGetpApp()->GetPool()));

Is this correct?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to