https://bugs.documentfoundation.org/show_bug.cgi?id=74580
Mike Kaganski <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|needsDevEval |difficultyInteresting, | |easyHack, skillCpp --- Comment #73 from Mike Kaganski <[email protected]> --- The way to fix this: 1. Introduce a new setting group, to hold the "always show filter settings" flag. The proposed place is under org.openoffice.Office.UI/FilePicker; it could be a subkey named "Filters" (similar to the multi-value setting group under org.openoffice.TypeDetection.Filter). There, for each filter name, the boolean flag will appear. Its initial value should be true (which means, by default, the filter options dialog will be automatically shown for all import filters). 2. In the File Open file pickers, add a "Edit filter settings" checkbox, similar to the same-name checkbox already existing in the Save As dialog. There should be an API change, allowing to control the active state and checked state of the introduced checkbox. 3. In the respective code executed when a filter is selected in the dialog, add a check similar to the code in the Save As dialog, to selectively enable the newly added checkbox; and a check of that respective flag added in org.openoffice.Office.UI/FilePicker, to decide if the checkbox should be automatically checked. 4. The filter should know the final decision from the file picker, and should open the settings dialog, when the checkbox was checked; and should simply use the last-used stored settings, if the checkbox was unchecked. This, again, should be implemented similar to how it is already working in Save As case. 5. The respective filter settings dialogs (e.g., the "text import" dialog in question specifically here), a "Always show on import" checkbox should be added. This checkbox must be possible to hide, because e.g. the dialog may be used in other contexts (e.g., here, the text import dialog is shown for Text to Columns command, where that new checkbox makes no sense). The checkbox should be automatically checked/unchecked on initialization to match the existing setting under org.openoffice.Office.UI/FilePicker; and on pressing OK, the setting must be updated in accordance with the user-defined state of the checkbox (which is where the user controls if the dialog will be always shown or not). This makes it possible to introduce a minimal and non-intrusive UI (two checkboxes), aligned with the already existing UI (the checkbox in File Open dialog would align with already familiar corresponding checkbox in Save As dialog; and the "always show" checkbox in filter settings dialogs would be consistent with other similar checkboxes of the same name, like e.g. in Tips of the Day, or in Confirm File Format dialog shown when saving in a non-default format case). It allows to create a well-defined behavior, where there is a setting controlling if the dialog for a specific filter is always shown (in the filter settings dialogs), and also a way to show it once, without automatically affecting the "show always" state (in the file picker dialog). -- You are receiving this mail because: You are the assignee for the bug.
