https://bugs.documentfoundation.org/show_bug.cgi?id=164072

Michael Weghorn <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #41 from Michael Weghorn <[email protected]> ---
While the commit from comment 39 was primarily targeted at the assert in debug
builds discussed earlier, I also cannot reproduce any crash on macOS with
current master.

It may be that the crash there was caused by the same underlying issue (menu
parent disposed while menu is still used).

When I revert the commit from comment 39 locally and comment the assert, I can
still reproduce another crash with the following backtrace on macOS:

1 rtl::Reference<vcl::Window>::get() const ref.hxx 205 0x111e505f0 
2 VclPtr<vcl::Window>::operator bool() const vclptr.hxx 187 0x111e6f2c8 
3 vcl::Window::GetWindowExtentsRelative(vcl::Window const&) const window.cxx
2929 0x112171cd8 
4 MenuFloatingWindow::doShutdown() menufloatingwindow.cxx 103 0x1120ab678 
5 PopupMenu::FinishRun(VclPtr<MenuFloatingWindow> const&, VclPtr<vcl::Window>
const&, bool, bool) menu.cxx 3106 0x1120992bc 
6 PopupMenu::ImplExecute(VclPtr<vcl::Window> const&, tools::Rectangle const&,
FloatWinPopupFlags, Menu *, bool) menu.cxx 3033 0x11209840c 
7 PopupMenu::Execute(vcl::Window *, tools::Rectangle const&, PopupMenuFlags)
menu.cxx 2860 0x112097198 
8
VCLXMenu::execute(com::sun::star::uno::Reference<com::sun::star::awt::XWindowPeer>
const&, com::sun::star::awt::Rectangle const&, short) vclxmenu.cxx 509
0x108864e4c 
9 SfxDispatcher::ExecutePopup(rtl::OUString const&, vcl::Window *, Point const
*) dispatch.cxx 1937 0x106fb0154 
10 SfxDispatcher::ExecutePopup(vcl::Window *, Point const *) dispatch.cxx 1785
0x106faf7b4 
11 sw::sidebarwindows::SidebarTextControl::Command(CommandEvent const&)
SidebarTxtControl.cxx 443 0x442bc7048 
12 weld::CustomWeld::DoCommand(CommandEvent const&) customweld.cxx 93
0x11284d438 
13 weld::CustomWeld::LinkStubDoCommand(void *, CommandEvent const&)
customweld.cxx 91 0x11284cf84 
14 Link<CommandEvent const&, bool>::Call(CommandEvent const&) const link.hxx
105 0x112002f6c 
15 SalInstanceDrawingArea::CommandHdl(CommandEvent const&) salvtables.cxx 6559
0x112897380 
16 SalInstanceDrawingArea::LinkStubCommandHdl(void *, CommandEvent const&)
salvtables.cxx 6557 0x112895000 
17 Link<CommandEvent const&, bool>::Call(CommandEvent const&) const link.hxx
105 0x112002f6c 
18 VclDrawingArea::Command(CommandEvent const&) layout.hxx 679 0x11206e704 
19 ImplCallCommand(VclPtr<vcl::Window> const&, CommandEventId, void const *,
bool, Point const *) winproc.cxx 229 0x1121877a0 
20 ImplHandleMouseEvent(VclPtr<vcl::Window> const&, NotifyEventType, bool,
long, long, unsigned long, unsigned short, MouseEventModifiers) winproc.cxx 798
0x112186ab0 
21 ImplHandleSalMouseButtonDown(vcl::Window *, SalMouseEvent const *)
winproc.cxx 2338 0x11218aeb4 
22 ImplWindowFrameProc(vcl::Window *, SalEvent, void const *) winproc.cxx 2683
0x112189cb8 
23 SalFrame::CallCallback(SalEvent, void const *) const salframe.hxx 311
0x1118cccf8 
24 -[SalFrameView sendMouseEventToFrame:button:eventtype:] salframeview.mm 1093
0x111976474 
25 -[SalFrameView rightMouseDown:] salframeview.mm 1160 0x111976a98 
26 _routeRightMouseDownEvent (arm64e)
/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit 0x19bb79308 
27 -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] (arm64e)
/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit 0x19b11bec4 
28 -[NSWindow(NSEventRouting) sendEvent:] (arm64e)
/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit 0x19b11bb50 
29 -[NSApplication(NSEventRouting) sendEvent:] (arm64e)
/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit 0x19b9580b8 
30 -[VCL_NSApplication sendEvent:] vclnsapp.mm 203 0x111982450 
31 AquaSalInstance::DoYield(bool, bool) salinst.cxx 609 0x1118e76d4 
32 ImplYield(bool, bool) svapp.cxx 385 0x112914a18 
33 Application::Yield() svapp.cxx 488 0x1129142d0 
34 Application::Execute() svapp.cxx 360 0x112913fac 
35 desktop::Desktop::Main() app.cxx 1679 0x100a6fe04 
36 ImplSVMain() svmain.cxx 230 0x112935fd8 
37 AquaSalInstance::handleAppDefinedEvent(NSEvent *) salinst.cxx 449
0x1118e68d8 
38 -[VCL_NSApplication sendEvent:] vclnsapp.mm 93 0x11198203c 
39 -[NSApplication _handleEvent:] (arm64e)
/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit 0x19b55f4e8 
40 -[NSApplication run] (arm64e)
/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit 0x19afe8088 
41 NSApplicationMain (arm64e)
/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit 0x19afbe854 
42 AquaSalInstance::SVMainHook(int *) salinst.cxx 1107 0x1118ebaec 
43 ImplSVMain() svmain.cxx 223 0x112935f8c 
44 SVMain() svmain.cxx 248 0x112937aac 
45 soffice_main sofficemain.cxx 122 0x100aef61c 
46 sal_main main.c 51 0x100003f70 
47 main main.c 49 0x100003f48 
48 start (arm64e) /usr/lib/dyld 0x197024274 

Frame 4 is making use of the parent window, which is already disposed at this
stage without the fix from comment 39.

Therefore, I'm somewhat optimistic that the original issue that this ticket was
about is fixed now, too. -> Closing this ticket as fixed.

@Reporter: A retest with a current daily build to see whether it's fine for you
as well now would be welcome. Feel free to reopen if it still crashes for you.

Version: 25.8.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: 4906f11d8f0c85248464b10c0b6c9c02e1657bad
CPU threads: 10; OS: macOS 15.2; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_DE.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to