https://bugs.documentfoundation.org/show_bug.cgi?id=165202

Michael Weghorn <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
           Assignee|[email protected] |[email protected]
                   |desktop.org                 |

--- Comment #6 from Michael Weghorn <[email protected]> ---
(In reply to Patrick (volunteer) from comment #5)
> So adding @Michael Weghorn to see if he has any insights into the locking
> code in accessibility::AccessibleBrowseBoxAccess::getAccessibleContext(). My
> memory is hazy, but I remember that tdf#148435 was caused by trying to lock
> a non-recursive mutex when it is already locked. In other words, tdf#148435
> was due to using a non-recursive lock as a recursive lock. On macOS, trying
> to lock a non-recursive lock that is already lock results in a hang so
> possibly we need to replace the lock with a recursive lock?

I agree, the backtrace suggests that's the problem. I actually ran into the
same issue while refactoring the AccessibleBrowseBox* classes and submitted

    commit 71d1432714b7aba0a10ca5d072c87e46ec325271
    Author: Michael Weghorn <[email protected]>
    Date:   Wed Feb 5 11:26:43 2025 +0100

        browsebox a11y: Use recursive mutex

on master. Backports for 25-2 and 25-2-1 now pending in Gerrit:

https://gerrit.libreoffice.org/c/core/+/181542
https://gerrit.libreoffice.org/c/core/+/181543 

> I can't tell from your sample if the mutex that
> accessibility::AccessibleBrowseBoxAccess::getAccessibleContext() is trying
> to lock is a non-recursive lock our not as, surprisingly, I couldn't find
> the code with a "grep -r AccessibleBrowseBoxAccess". :/

That class is no more on master. I dropped it while refactoring BrowseBox a11y
code, see `git log --grep="browsebox a11y"`, in particular

    commit cc8d3dac879ce8be66b785efdfe62be4ca6676bd
    Author: Michael Weghorn <[email protected]>
    Date:   Thu Feb 6 10:17:47 2025 +0100

        browsebox a11y: Drop AccessibleBrowseBoxAccess

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to