https://bugs.documentfoundation.org/show_bug.cgi?id=165433

--- Comment #32 from Robin Candau <[email protected]> ---
We were able to fix the issue.

The culprit is
https://git.libreoffice.org/core/+/refs/heads/master/sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.cxx#112

Indeed, as pointed by codestation
(https://bugs.documentfoundation.org/show_bug.cgi?id=165433#c15), since poppler
25.02.0, GlobalParams doesn't have a constructor that accepts a nullptr anymore
(see
https://gitlab.freedesktop.org/poppler/poppler/-/commit/b50390f748b59cb0a64b912636ecf6527bd0d12a).

As such, the data directory location defined for SYSTEM_POPPLER have to be
updated accordingly (if SYSTEM_POPPLER >= 25.02.0).

Here is the patch we applied (also available in the attachments):

```
diff --git a/sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.cxx
b/sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.cxx
index ebed12070..9b63559be 100644
--- a/sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.cxx
+++ b/sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.cxx
@@ -110,7 +110,11 @@ int main(int argc, char **argv)

     /* Get data directory location */
 #ifdef SYSTEM_POPPLER
+#if POPPLER_CHECK_VERSION(25, 0, 2)
+    const std::string datadir = "";
+#else
     const char* datadir = nullptr;
+#endif
 #else
     /* Creates an absolute path to the poppler_data directory, by taking the
path
      * to the xpdfimport executable (provided in argv[0], and concatenating a
```

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to