https://bugs.documentfoundation.org/show_bug.cgi?id=82262

--- Comment #25 from Dave Gilbert <[email protected]> ---
(In reply to zllangty from comment #24)
> Created attachment 199734 [details]
> Enable tiling pattern fill get better result
> 
> I try use inkscape open the minimal files, it show the shape fill with
> pattern.
> and I checked `PDFOutDev::tilingPatternFill` may fallback to slow method use
> clippath, After comment out these code and we can get better result with
> tilingPatternFill. remaining issue only the pattern not same with original
> file.

Yep, I'd spotted they were tilingPatternFill; but it's a fun problem:
  a) I think the fallback is only taken because of a rounding comparison; my
debug notes have:
    1250      if (xStep != nWidth || yStep != nHeight)
    (gdb) p xStep
    $1 = 21
    (gdb) p nWidth
    $2 = 20.999999999999996
    (gdb) p yStep
    $3 = 21
    (gdb) p nHeight
    $4 = 21.000000000000004

  so we can probably fix that easily

  b) But it feels like we should fix the clipping problem anyway!

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to