https://bugs.documentfoundation.org/show_bug.cgi?id=166407

Julien Nabet <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected],
                   |                            |olivier.hallot@libreoffice.
                   |                            |org, [email protected]
                 OS|Windows (All)               |All

--- Comment #2 from Julien Nabet <[email protected]> ---
I found 2 ways to fix this:
1)
diff --git a/source/text/scalc/01/func_value.xhp
b/source/text/scalc/01/func_value.xhp
index 03ac5f4701..c1885715d3 100644
--- a/source/text/scalc/01/func_value.xhp
+++ b/source/text/scalc/01/func_value.xhp
@@ -17,7 +17,7 @@
 </meta>
 <body>
   <section id="func_value">
-    <bookmark id="bm_id61542230672099" xml-lang="en-US"
branch="hid/SC_HID_FUNC_VALUE" localize="false"/>
+    <bookmark id="bm_id61542230672099" xml-lang="en-US"
branch="hid/SC_HID_FUNC_WERT" localize="false"/>
     <bookmark xml-lang="en-US" branch="index" id="bm_id831542233029549">
       <bookmark_value>VALUE function</bookmark_value>
       <bookmark_value>text functions;convert text to numeric
value</bookmark_value>

or

2)
diff --git a/sc/inc/helpids.h b/sc/inc/helpids.h
index 8aaf758181ef..48794f18f22e 100644
--- a/sc/inc/helpids.h
+++ b/sc/inc/helpids.h
@@ -470,7 +470,7 @@ inline constexpr OUString HID_FUNC_GLAETTEN =
u"SC_HID_FUNC_GLAETTEN"_ustr;
 inline constexpr OUString HID_FUNC_GROSS2 = u"SC_HID_FUNC_GROSS2"_ustr;
 inline constexpr OUString HID_FUNC_GROSS = u"SC_HID_FUNC_GROSS"_ustr;
 inline constexpr OUString HID_FUNC_KLEIN = u"SC_HID_FUNC_KLEIN"_ustr;
-inline constexpr OUString HID_FUNC_WERT = u"SC_HID_FUNC_WERT"_ustr;
+inline constexpr OUString HID_FUNC_VALUE = u"SC_HID_FUNC_VALUE"_ustr;
 inline constexpr OUString HID_FUNC_TEXT = u"SC_HID_FUNC_TEXT"_ustr;
 inline constexpr OUString HID_FUNC_T = u"SC_HID_FUNC_T"_ustr;
 inline constexpr OUString HID_FUNC_ERSETZEN = u"SC_HID_FUNC_ERSETZEN"_ustr;
diff --git a/sc/source/core/data/funcdesc.cxx
b/sc/source/core/data/funcdesc.cxx
index 995f4dd76103..a0d371a32258 100644
--- a/sc/source/core/data/funcdesc.cxx
+++ b/sc/source/core/data/funcdesc.cxx
@@ -466,7 +466,7 @@ ScFunctionList::ScFunctionList( bool bEnglishFunctionNames
)
         { SC_OPCODE_LOWER, ENTRY(SC_OPCODE_LOWER_ARY), 0,
ID_FUNCTION_GRP_TEXT, HID_FUNC_KLEIN, 1, { 0 }, 0 },
         { SC_OPCODE_LEN, ENTRY(SC_OPCODE_LEN_ARY), 0, ID_FUNCTION_GRP_TEXT,
HID_FUNC_LAENGE, 1, { 0 }, 0 },
         { SC_OPCODE_T, ENTRY(SC_OPCODE_T_ARY), 0, ID_FUNCTION_GRP_TEXT,
HID_FUNC_T, 1, { 0 }, 0 },
-        { SC_OPCODE_VALUE, ENTRY(SC_OPCODE_VALUE_ARY), 0,
ID_FUNCTION_GRP_TEXT, HID_FUNC_WERT, 1, { 0 }, 0 },
+        { SC_OPCODE_VALUE, ENTRY(SC_OPCODE_VALUE_ARY), 0,
ID_FUNCTION_GRP_TEXT, HID_FUNC_VALUE, 1, { 0 }, 0 },
         { SC_OPCODE_CLEAN, ENTRY(SC_OPCODE_CLEAN_ARY), 0,
ID_FUNCTION_GRP_TEXT, HID_FUNC_SAEUBERN, 1, { 0 }, 0 },
         { SC_OPCODE_CHAR, ENTRY(SC_OPCODE_CHAR_ARY), 0, ID_FUNCTION_GRP_TEXT,
HID_FUNC_ZEICHEN, 1, { 0 }, 0 },
         { SC_OPCODE_LOG10, ENTRY(SC_OPCODE_LOG10_ARY), 0,
ID_FUNCTION_GRP_MATH, HID_FUNC_LOG10, 1, { 0 }, 0 },


I'd prefer solution 2 since we should replace German language by English
language (WERT -> VALUE) but perhaps there are good reasons here to keep German
language?

Eike: any thoughts here?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to