https://bugs.freedesktop.org/show_bug.cgi?id=66242

--- Comment #10 from Markus Mohrhard <[email protected]> ---
(In reply to comment #9)
> (In reply to comment #6)
> > > > There is something strange with the formatting of the cells in the 
> > > > original
> > > > file too. Look at the decimal/thousand separators.
> > > 
> > > For the number formats you're a victim of cached values that are 
> > > displayed.
> > > Hit Shift+Ctrl+F9 to get the separators of your locale. Cc'ing Moggi.
> > 
> > The problem with the cached values should be gone in 4.1.0.2 because we no
> > longer use the string. Every cell has now an hard number format after import
> > and the code for my ugly hack has been removed.
> 
> This is something different. The number format says to "format with decimal
> and group separator of the current locale", so the actual display string
> should change when loaded in a locale that uses different separators. It
> sounds as if that will not be covered by the changes, or am I wrong?

Why should that not be fixed with my code? We now don't import the cached
string anymore, we always use a number format and the cached value!! to
calculate the string. In the old code we used the cached string to workaround
the missing inherited number formats but all of this code should be gone in
master and 4.1.0.2.

I also have a fix for this bug here which is a regression. I accidentally
removed the code that fetched the number format for formula cells.

If I'm not totally off in the current design there is no difference between a
document that has been recalculated after import and a document where we use
the cached value during import. In both cases we take the value of the result
(either calculated or cached) and use the stored(either from import or in case
of inherited number format from the first calculation) number format from
ATTR_VALUE_FORMAT to create the formatted string. The only difference to the
old 3.6 behavior is that for inherited number format we set the implicit number
format as explicit number format after calculation. Please correct me if I made
a really stupid mistake.

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to