[Bug 168375] LibreOffice Calc hijacks command-option-space on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=168375

--- Comment #3 from Patrick (volunteer) <guibomac...@gmail.com> ---
Below is a debug patch that stops the bug from occurring. It isn't a fix but I
think the next step would be to follow pChild->KeyInput( aKeyEvt ); in a
debugger to see where it ends up converting Command-Option-Space to a Space
event:

diff --git a/vcl/source/window/winproc.cxx b/vcl/source/window/winproc.cxx
index a75eb6ada250..1d4d3d421f20 100644
--- a/vcl/source/window/winproc.cxx
+++ b/vcl/source/window/winproc.cxx
@@ -1232,8 +1232,10 @@ static bool ImplHandleKey( vcl::Window* pWindow,
NotifyEventType nSVEvent,
         if ( nSVEvent == NotifyEventType::KEYINPUT )
         {
             UITestLogger::getInstance().logKeyInput(pChild, aKeyEvt);
-            pChild->ImplGetWindowImpl()->mbKeyInput = false;
-            pChild->KeyInput( aKeyEvt );
+            // Commenting out the following stops Command-Option-Space
+            // from inserting a space in Calc and Impress
+            // pChild->ImplGetWindowImpl()->mbKeyInput = false;
+            // pChild->KeyInput( aKeyEvt );
         }
         else
         {
@@ -1314,6 +1316,10 @@ static bool ImplHandleKey( vcl::Window* pWindow,
NotifyEventType nSVEvent,
             else
                 bRet = false;
         }
+        // Adding the following makes Command-Option-Space change the
+        // current input source in Calc and Impress
+        else
+            bRet = false;
     }
     else
     {

-- 
You are receiving this mail because:
You are the assignee for the bug.