https://bugs.documentfoundation.org/show_bug.cgi?id=152817
Justin L <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] OS|Linux (All) |All Priority|medium |lowest Status|NEW |RESOLVED Version|7.6.0.0 alpha0+ |Inherited From OOo Assignee|[email protected] |[email protected] |desktop.org | Resolution|--- |FIXED Severity|normal |trivial --- Comment #7 from Justin L <[email protected]> --- That has been there since the file was introduced. commit 66c724a878a15a8d5cf4d084c6e3feaba280ecee Author: Rüdiger Timm on Fri Sep 17 13:01:49 2004 +0000 INTEGRATION: CWS os19 (1.1.2); FILE ADDED It is being called by SpellDialog::GetNextSentence_Impl rParent.ApplyChangedSentence(m_xSentenceED->CreateSpellPortions(), ... Since svx::SpellPortions CreateSpellPortions() const; that should mean that there are no side implications (no changes/modifications to m_xSEntenceED) right? So in theory then we could just avoid this call without causing any bad side effects. I don't see any const_cast's here either, so it really should be a constant, non-modifying, OPTIONAL event. ApplyChangedSentence returns immediately if m_bInitialCall, so it is OPTIONAL as well. Heh - but everything I've concluded so far is irrelevant. GetNextSentence_Impl doesn't know it is in Initialize, so there is no flag to say the call to ApplyChangedSentence is not necessary. -- You are receiving this mail because: You are the assignee for the bug.
