https://bugs.documentfoundation.org/show_bug.cgi?id=168709

Saburo <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #11 from Saburo <[email protected]> ---
bibisected with win64-7.2
f4fb2751ed6f66bf11f9e6c70471d53f14513f68 is the first bad commit
    source sha:cfff893b9c82843a90aac4ecdb3a3936721b74a0


commit  cfff893b9c82843a90aac4ecdb3a3936721b74a0
author  Mike Kaganski <[email protected]>     Sat Feb 13 13:55:22
2021 +0300

Move unit conversion code to o3tl, and unify on that in more places

This also allows to easily add more units, both of length and for other
unit categories.

The conversion for "Line" unit (312 twip) is questionable. Corresponding
entries in aImplFactor in vcl/source/control/field.cxx were inconsistent
(45/11 in; 10/13 pc; 156/10 pt). They were added without explanation in
commit c85db626029fd8a5e0dfcb312937279df32339a0. I haven't found a spec
of the unit (https://en.wikipedia.org/wiki/Line_(unit) is not specific).
I used the definition based on "by pt", "by mm/100", "by char" (they all
were consistent); "by pc" seems inverted; "by twip" was half as much.
This accepted conversion makes unit test for tdf#79236 pass.

***
adding CC: Mike Kaganski

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to