https://bugs.documentfoundation.org/show_bug.cgi?id=170120
--- Comment #6 from [email protected] <[email protected]> --- (In reply to Patrick (volunteer) from comment #2) > (In reply to [email protected] from comment #1) > > Patrick, any thoughts on what we should do here? I presume the bBright code > > is there for a reason... We just got tripped up by Tahoe again I guess? > > Not sure if this is too hacky, but the following debug patch works in my > local build without having to mess with the bBright code. Note: this bug > doesn't appear in Dark Mode since [NSColor windowBackgroundColor] returns > 0x1e1e1e: Yeah I thought about something like this too, and that's probably what I'll end up going with. But I wonder if something in Tahoe changed WRT window backgrounds as materials instead of plain colors? --- After staring at the code for a couple of days I think I have a better solution, which is to make the bBright code not check COL_WHITE but check GetHighContrastMode() instead which was its original intent. > > diff --git a/vcl/osx/salframe.cxx b/vcl/osx/salframe.cxx > index ca5938b48431..5573984367e8 100644 > --- a/vcl/osx/salframe.cxx > +++ b/vcl/osx/salframe.cxx > @@ -1628,6 +1628,9 @@ SAL_WNODEPRECATED_DECLARATIONS_POP > Color aWindowBackgroundColor(getNSBoxBackgroundColor([NSColor > windowBackgroundColor])); > Color aUnderPageBackgroundColor(getNSBoxBackgroundColor([NSColor > underPageBackgroundColor])); > > + if (aWindowBackgroundColor == COL_WHITE) > + aWindowBackgroundColor = Color(0xf7, 0xf7, 0xf7); > + > // Background Color > aStyleSettings.BatchSetBackgrounds( aWindowBackgroundColor, false ); > aStyleSettings.SetLightBorderColor( aWindowBackgroundColor ); -- You are receiving this mail because: You are the assignee for the bug.
