https://bugs.documentfoundation.org/show_bug.cgi?id=170297

Mike Kaganski <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #10 from Mike Kaganski <[email protected]> ---
(In reply to [email protected] from comment #8)
> But when I understand right the answer of Mike Kaganski in Comment 7 it was
> still not active (enabed only by his change
> 1a4f72f03b1bd49d486e52135e78971242fae649 from 2025-10-11 15:28:03 UTC). OK?

Yes.

Balazs: is implementing commit 1b5d039d8b5861b5ea21ef00ff521c6e2565105f, and
his WIP passes a temporary PrivilegeSet to AccessCheck. Adds Mike as a
reviewer.

Mike: reads it, checks the documentation of AccessCheck, sees that PrivilegeSet
is documented optional, and suggest to avoid that instead.

Balazs: follows Mike's advise, and merges commit
1b5d039d8b5861b5ea21ef00ff521c6e2565105f.

Mike: sees the commit has been merged, pulls fresh master, builds, and tests -
and sees that the intended functionality is not working at all. He debugs it,
and sees that the call to AccessCheck fails; he tests that the failure is
causes by not passing PrivilegeSet to it; then he creates and merges follow up
commit 1a4f72f03b1bd49d486e52135e78971242fae649, which result is simply
"Balazs' original change".

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to